Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Create BackToTop component #139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/BackToTop.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import React from "react";
import { forwardRef, memo } from "react";
import { cx } from "./tools/cx";
import { fr } from "./fr";
import { symToStr } from "tsafe/symToStr";
import { createComponentI18nApi } from "./i18n";

export type BackToTopProps = {
anchor?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no anchor is explicitely provided the default behaviour shoud be to scroll sroll smoothly to the top of the page.
In this case you'll have to use a <button /> component since it's not accible to use a <a /> without a valid href. We need to apply the fr-link class to the button to make it look a <a />.
Beside it's ok accept a css selector but the recomended approach should be to provide ref. Dsfr components do not allow to provide html id but all enable to provide ref.

/** Default: false (the back to top button is centered) */
right?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
right?: boolean;
/** Default: false (the back to top button is centered) */
right?: boolean;

};

export const BackToTop = memo(
forwardRef<HTMLAnchorElement, BackToTopProps>((props, ref) => {
const { t } = useTranslation();
const { anchor = "#top", right = false } = props;
return (
<div className={!right ? undefined : fr.cx("fr-grid-row", "fr-grid-row--right")}>
<a
ref={ref}
className={cx(fr.cx("fr-link", "fr-icon-arrow-up-fill", "fr-link--icon-left"))}
href={anchor}
>
{t("page top")}
</a>
</div>
);
})
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want export default

Suggested change
export default BackToTop;

BackToTop.displayName = symToStr({ BackToTop });

export default BackToTop;

const { useTranslation, addBackToTopTranslations } = createComponentI18nApi({
"componentName": symToStr({ BackToTop }),
"frMessages": {
"page top": "Haut de page"
}
});

addBackToTopTranslations({
lang: "en",
messages: {
"page top": "Top of the page"
}
});
30 changes: 30 additions & 0 deletions stories/BackToTop.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import { BackToTop } from "../dist/BackToTop";
import { getStoryFactory } from "./getStory";
import { sectionName } from "./sectionName";

const { meta, getStory } = getStoryFactory({
sectionName,
"wrappedComponent": { BackToTop },
"description": `- [See DSFR documentation](https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/retour-en-haut-de-page/)
- [See source code](https://github.com/codegouvfr/react-dsfr/blob/main/src/BackToTop.tsx)`,
"argTypes": {
"anchor": {
"control": { "type": null },
"defaultValue": "#top",
"description": "The #anchor for the corresponding HTML id"
},
"right": {
"control": "boolean",
"defaultValue": false,
"description": "Align to right"
}
},
"disabledProps": ["lang"]
});

export default meta;

export const Default = getStory({});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to have a story for when the back to top is to the right.

export const BackToTopOnRight = getStory({
right: true
});