-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string optimizations #521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
May 7, 2024
Shane32
commented
May 7, 2024
Shane32
commented
May 7, 2024
Shane32
commented
May 7, 2024
Shane32
commented
May 7, 2024
gfoidl
reviewed
May 9, 2024
Hello @gfoidl , hello @Shane32 - I would like to take this opportunity to say once again that I am very impressed by your suggestions and your discussion. To be honest, your optimizations reach a level that exceeds my knowledge of C#/.NET/JIT. Nevertheless, I think I vaguely understand what you are discussing and I think I have learned a thing or two. Thank you very much for your efforts. I bow my head! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
PlainTextToBinaryByte
from encoding the provided string back and forth to the target encoding multiple times. It also caches the encoder for future use, as it is designed to be a singleton. On the .NET Core 5+ TFMs the encoding uses a stack-allocated byte array, reducing heap allocations and memory requirements.Add tests for UTF8 with and without BOM.
No changes to logic; produced QR codes should be identical to previously for any input.