systemd: drop unrequired validated

validated shadows helperTextInvalid in a sense, so we can simply pass helperTextInvalid instead. Found by Github code scanning.
cockpit-project · Jun 20, 2023 · 934a4e3 · 934a4e3
1 parent 483027a
commit 934a4e3
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pkg/systemd/timer-dialog.jsx b/pkg/systemd/timer-dialog.jsx
@@ -266,20 +266,17 @@ const CreateTimerDialogBody = ({ owner }) => {
                                 label = _("Run on");
 
                             let helperTextInvalid;
-                            let validated = "default";
                             const min = repeatPatterns[idx].minute;
                             const validationFailedMinute = !(/^[0-9]+$/.test(min) && min <= 59 && min >= 0);
 
                             if (submitted && repeat == 'hourly' && validationFailedMinute) {
-                                validated = "error";
                                 helperTextInvalid = _("Minute needs to be a number between 0-59");
                             }
 
                             const sec = repeatPatterns[idx].second;
                             const validationFailedSecond = !(/^[0-9]+$/.test(sec) && sec <= 59 && sec >= 0);
 
                             if (submitted && repeat == 'minutely' && validationFailedSecond) {
-                                validated = "error";
                                 helperTextInvalid = _("Second needs to be a number between 0-59");
                             }
 
@@ -388,7 +385,7 @@ const CreateTimerDialogBody = ({ owner }) => {
                                             </InputGroup>
                                         </FlexItem>}
                                     </Flex>
-                                    <FormHelper helperTextInvalid={validated && helperTextInvalid} />
+                                    <FormHelper helperTextInvalid={helperTextInvalid} />
                                 </FormGroup>
                             );
                         })}