Add tests #64
Open
Add tests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Typescript contents are moved to root dir to match with extension dir layout - Renamed lmod to module - Added handlers to get found module system name and logo - Renamed most of the instances of lmod to module except for pkg name - Added Lmod and Tmod logos to static dir - Added editable build command to pyproject.toml - Added npm-run-all to package.json - Changed extension named to @jupyterlab/jupyterlab-lmod to match standard convention - Included yarn.lock with repo - Added install.json file
Set correct EMPTY_LIST_STR for each module system Fix print_output_decorator by making it async Improve module list logic by properly catching hidden modules Remove header in savelist if present
Please do. I am using shared-runners. |
This is very rudimentary. Most probably there will be failed tests.
|
Added a preliminary test workflow. I adopted the one from |
This is needed for coverage to generate cov report properly
|
@mahendrapaipuri better late than never they say. Could you rebase this on main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic tests for the package. Currently, we implemented the tests for
modulepackage and we are also testinghandlers.All fixtures are defined in
conftest.pyand we are reusing them in tests formoduleandhandlers.@cmd-ntrf Can I add a workflow to test these tests in CI? I did not add it now as I am not sure if you are using shared runners (with quota) or your on-premise runners.