Revert "refactor(core): Remove RootViewRef<T> because it is the same …

…as ViewRef<T> (angular#52430)" (angular#52484)

This reverts commit a3028e2 as it breaks
tests in g3.

PR Close angular#52484

packages/core/src/render3/component_ref.ts

@@ -51,7 +51,7 @@ import {computeStaticStyling} from './styling/static_styling';
 import {mergeHostAttrs, setUpAttributes} from './util/attrs_utils';
 import {debugStringifyTypeForError, stringifyForError} from './util/stringify_utils';
 import {getComponentLViewByIndex, getNativeByTNode, getTNode} from './util/view_utils';
-import {ViewRef} from './view_ref';
+import {RootViewRef, ViewRef} from './view_ref';
 
 export class ComponentFactoryResolver extends AbstractComponentFactoryResolver {
   /**
@@ -319,11 +319,7 @@ export class ComponentRef<T> extends AbstractComponentRef<T> {
       private _tNode: TElementNode|TContainerNode|TElementContainerNode) {
     super();
     this.instance = instance;
-    this.hostView = this.changeDetectorRef = new ViewRef<T>(
-        _rootLView,
-        undefined, /* _cdRefInjectingView */
-        false,     /* notifyErrorHandler */
-    );
+    this.hostView = this.changeDetectorRef = new RootViewRef<T>(_rootLView);
     this.componentType = componentType;
   }
 

packages/core/src/render3/view_ref.ts

@@ -57,7 +57,7 @@ export class ViewRef<T> implements EmbeddedViewRef<T>, InternalViewRef, ChangeDe
        *
        * This may be different from `_lView` if the `_cdRefInjectingView` is an embedded view.
        */
-      private _cdRefInjectingView?: LView, private readonly notifyErrorHandler = true) {}
+      private _cdRefInjectingView?: LView) {}
 
   get context(): T {
     return this._lView[CONTEXT] as unknown as T;
@@ -284,8 +284,7 @@ export class ViewRef<T> implements EmbeddedViewRef<T>, InternalViewRef, ChangeDe
    * See {@link ChangeDetectorRef#detach} for more information.
    */
   detectChanges(): void {
-    detectChangesInternal(
-        this._lView[TVIEW], this._lView, this.context as unknown as {}, this.notifyErrorHandler);
+    detectChangesInternal(this._lView[TVIEW], this._lView, this.context as unknown as {});
   }
 
   /**
@@ -296,8 +295,7 @@ export class ViewRef<T> implements EmbeddedViewRef<T>, InternalViewRef, ChangeDe
    */
   checkNoChanges(): void {
     if (ngDevMode) {
-      checkNoChangesInternal(
-          this._lView[TVIEW], this._lView, this.context as unknown as {}, this.notifyErrorHandler);
+      checkNoChangesInternal(this._lView[TVIEW], this._lView, this.context as unknown as {});
     }
   }
 

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

@@ -443,6 +443,9 @@
   {
     "name": "RendererStyleFlags2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -821,6 +824,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/animations/bundle.golden_symbols.json

@@ -485,6 +485,9 @@
   {
     "name": "RootComponent"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -884,6 +887,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

@@ -368,6 +368,9 @@
   {
     "name": "RendererStyleFlags2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -665,6 +668,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/defer/bundle.golden_symbols.json

@@ -419,6 +419,9 @@
   {
     "name": "RendererStyleFlags2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -755,6 +758,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

@@ -506,6 +506,9 @@
   {
     "name": "RootComponent"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -908,6 +911,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

@@ -494,6 +494,9 @@
   {
     "name": "RootComponent"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -878,6 +881,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/hello_world/bundle.golden_symbols.json

@@ -281,6 +281,9 @@
   {
     "name": "RendererFactory2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -524,6 +527,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/hydration/bundle.golden_symbols.json

@@ -428,6 +428,9 @@
   {
     "name": "RendererStyleFlags2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -749,6 +752,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/router/bundle.golden_symbols.json

@@ -629,6 +629,9 @@
   {
     "name": "ResolveStart"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RouteConfigLoadEnd"
   },
@@ -1178,6 +1181,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

@@ -332,6 +332,9 @@
   {
     "name": "RendererStyleFlags2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -596,6 +599,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },

packages/core/test/bundling/todo/bundle.golden_symbols.json

@@ -395,6 +395,9 @@
   {
     "name": "RendererStyleFlags2"
   },
+  {
+    "name": "RootViewRef"
+  },
   {
     "name": "RuntimeError"
   },
@@ -794,6 +797,9 @@
   {
     "name": "detectChangesInViewIfAttached"
   },
+  {
+    "name": "detectChangesInternal"
+  },
   {
     "name": "diPublicInInjector"
   },