Improve performance by only using FiberHandler for ReactiveHandler
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves performance by only using
FiberHandlerforReactiveHandler. In particular, the traditional PHP SAPIs and the newApp::__invoke()method do not need to start a fiber for each request.On my machine, the
App::__invoke()is now ~40% faster consistently (16s -> 10s for 1M invocations) and the PHP development web server is ~10% faster (2000rps -> 2200rps). The performance of the built-in web server is unchanged as expected (14000rps).Besides performance improvements, this also allows us to clean up a number of now unneeded checks in the test suite and simplify quite a few tests a bit.
Builds on top of #236, #224, #128, #117 and others