Expose variable s3_object_ownership #67
Conversation
Terraform code using this module could require different values than the default, for `s3_object_ownership`. Specifically, this will allow us to fix cloudposse/terraform-aws-ecs-web-app#225, which is currently failing when trying to create ACLs, with error: > AccessControlListNotSupported: The bucket does not allow ACLs
Makefile
Outdated
| @@ -1,4 +1,5 @@ | |||
| SHELL := /bin/bash | |||
| export TERRAFORM_VERSION = 1.3.9 | |||
There was a problem hiding this comment.
Any specific reason to pin this version here? I haven't seen this elsewhere, so I'm inclined to say we shouldn't do this.
There was a problem hiding this comment.
I couldn't make make lint pass without this change, as build-harness downloads Terraform 1.0 by default (related code).
I saw this implemented here: https://github.com/cloudposse/terraform-aws-s3-bucket/blob/d3c353f3170347352684b04a75cb62d4bc91ba6e/Makefile#L2
However, I don't think CI runs make lint? As https://github.com/cloudposse/terraform-aws-s3-log-storage doesn't include this line, but it requires Terraform >= 1.3.0, running make lint in that project also fails.
|
/terratest |
|
Pulling in @Nuru on this PR as I know he was the one who untangled the S3 bucket ACL / policy changes in our most basic S3 child module. Figured he should weigh in here on how changes like this should proceed. |
|
@Nuru any update re this ? |
|
@Gowiem can you also have a recheck re this pr to get it moving again? |
|
@adamantike Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness. |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
|
/terratest |
|
/terratest |
|
/terratest |
Nuru
added
the
no-release
|
Released in v0.20.0 |
what
s3_object_ownershipvariable for passthrough to thecloudposse/s3-log-storage/awsmodule.1.3.0, which is already required by the underlying modulecloudposse/s3-log-storage/aws(reference).why
Terraform code using this module could require different values than the default, for
s3_object_ownership.Specifically, this will allow us to fix cloudposse/terraform-aws-ecs-web-app#225, which is currently failing when trying to create ACLs, with error: