This repository has been archived by the owner on Jul 3, 2021. It is now read-only.
Decouple cfcr #399
Open
Decouple cfcr #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Hey lubronzhan! All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process. The following github users: @lubronzhan @pydctw are not covered by a CLA. After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s). |
neil-hickey
reviewed
May 29, 2019
| @@ -4,5 +4,5 @@ vm_extensions: | |||
| service_account: ((cfcr_master_service_account_address)) | |||
| name: ((deployment_name))-master-cloud-properties | |||
| - cloud_properties: | |||
| service_account: ((cfcr_worker_service_account_address)) | |||
| service_accoqunt: ((cfcr_worker_service_account_address)) | |||
lubronzhan
force-pushed
the
decouple_cfcr
branch
from
bd77c73
to
f8a145b
Compare
[#165551713] Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com>
[#165551713]
[#165551713]
[#165551713] Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com> Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com> Signed-off-by: Carlo Colombo <ccolombo@pivotal.io>
Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com> Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com> Signed-off-by: Carlo Colombo <ccolombo@pivotal.io>
Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com>
Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com>
Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com>
This reverts commit cafdd2f.
[#165551713] Co-authored-by: Winnie Kwon <lkwon@pivotal.io> Co-authored-by: Lubron Zhan <lzhan@vmware.com>
lubronzhan
force-pushed
the
decouple_cfcr
branch
from
f8a145b
to
264c608
Compare
Signed-off-by: Lubron Zhan <lzhan@vmware.com>
[#165551713] Signed-off-by: Winnie Kwon <lkwon@pivotal.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Decoupled cfcr from kubernetes.
Moved all k8s binaries to https://github.com/cloudfoundry-incubator/kubernetes-release
How can this PR be verified?
manually create kubo-release on this branch and create kubernetes-release on kubernetes-release
v1.14.xbranch, then deploy them withkubo-deploymentdecouple_cfcrbranchIs there any change in kubo-release?
cloudfoundry-incubator/kubo-release#324
Is there any change in kubo-ci?
will be
Does this affect upgrade, or is there any migration required?
no
Which issue(s) this PR fixes:
https://www.pivotaltracker.com/story/show/165551713
Release note: