feat: provide support for Kafka message keys different than "string?"

[Abuntxa]

This pull request implements support for Kafka Message key types other than "string?".

[jskeet]

A couple of comments to streamline changes later, but I won't have time to review the actual code until next week.

[jskeet]

(Just to keep communicating - this is still on my plate, but keeps being bumped by higher priority things. I promise I'll get to it eventually...)

[Abuntxa]

I tried 2 different approaches for my same problem:

• Consume external dapr generated messages natively. This was considered first, as we already were consuming other non cloud event messages from kafka and didn't ourselves use dapr. It required this PR to succeed in order to be able to complete it.
• Use dapr too for consuming these external dapr generated messages.

The cloud event had extended properties with the tenant information and due to a lack of proper examples I thought it would not be possible to get a hold of that tenant information using Dapr (all examples seemed to handle the payload of the cloud event and not the whole cloud event).

I turns out that by not using the middleware added with ".UseCloudEvents()" and parsing the cloud event directly using the extension methods provided in this repository did the trick.

Therefore, the Pull request won't be necessary from my part, although I think that other people could find it interesting (specially for binary key support).

Some notes regarding the dapr implementation
During the development I missed a proper parameter binding implementation that would allow binding CloudEvents to controller method parameters. A generic CloudEvent< T > where the T would be the expected payload for deserialization could have made the trick. This would make the development easy while giving full access to the cloud envelope for accessing the custom properties.

[jskeet]

Thanks so much for the update - that's really good to know. I was hoping to review this in the next couple of days, but I was getting queasy about it, knowing how little I know about Kafka.

I suggest we just leave the PR open for a little while, and see whether it attracts any attention from other users. Does that work for you?

[Abuntxa]

It's fine for me. Thank you for looking into it El mié, 9 oct 2024, 8:34, Jon Skeet ***@***.***> escribió:

…

Thanks so much for the update - that's really good to know. I was hoping to review this in the next couple of days, but I was getting queasy about it, knowing how little I know about Kafka. I suggest we just leave the PR open for a little while, and see whether it attracts any attention from other users. Does that work for you? — Reply to this email directly, view it on GitHub <#314 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7WOGN5LURL7YN3TLBZJDTZ2TE6ZAVCNFSM6AAAAABO4XF7AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGQZTINZZGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>