Upgrade to Ktor Server 3.0.1 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to Ktor Server 3.0.1 means letting go of the 'principal' parameter to the controller functions. The [Principal interface](https://api.ktor.io/ktor-server/ktor-server-plugins/ktor-server-auth/io.ktor.server.auth/-principal/index.html) is no longer available and thus we cannot provide a common supertype of the different Principals. Instead the user should get the principal with `call.principal<P>()` in the implementation.
ulrikandersen
force-pushed
the
ktor-server-3.0.1
branch
from
cfbc858
to
219c780
Compare
cjbooms
approved these changes
Nov 29, 2024
No worries at all ✌️ I am not in a hurry to get a new major version out, but I will ping in case that changes. I am also working on a fix for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the Ktor Controller Interface Generator to support Ktor Server 3.0.1.
Upgrading to Ktor Server 3.0.1 means letting go of the 'principal' parameter to the controller functions. The Principal interface is no longer available and thus we cannot provide a common supertype of the different Principals. Instead the user should get the principal with
call.principal<P>()in the implementation. This will work just fine with Ktor 2.3.x too.