tweak(compiler/linux): build portability #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems, this is already defined by default or via compiler-options, re-defining there is unwanted.
On some systems (like Ubuntu) netinet headers get included by default. In those cases, we are re-defining system macros without undefining them first, which makes building fail.
github-actions
bot
added
the
invalid
prikolium-cfx
approved these changes
Nov 5, 2024
prikolium-cfx
added
ready-to-merge
|
Thanks for your contribution. Let's try :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
On some systems (like Ubuntu) netinet headers get included by default. In those cases, we are re-defining system macros without undefining them first, which makes building fail.
This fixes building on native Ubuntu, so this should revive Github Runners once again.
https://github.com/tens0rfl0w/fivem/actions/runs/11621071896/job/32364102250
How is this PR achieving the goal
_GNU_SOURCEmacro__bswap_*macros before re-defining themThis PR applies to the following area(s)
Source compiling (Linux)
Successfully tested on
Game builds: Not applicable
Platforms: Linux (Github Runners - ubuntu-20.04)
Checklist
Fixes issues
/