fix(game/five): verify pickup weapon component is valid on creation ( again, but proper ) #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
invalid
|
Is the cheater taking down every player that some fix date goes into production? @FabianTerhorst @iridium-cfx |
iridium-cfx
approved these changes
Oct 28, 2024
FabianTerhorst
added
ready-to-merge
slashkeyvalue
deleted the
fix/pickup-creation-invalid-weap-comp-improved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Prevent crash caused by invalid pickup weapon components on pickup creation.
This is an improvement on #2797 which was absolutely garbage.
How is this PR achieving the goal
Adds proper validations on pickup creation
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 2060, 2699, 2802, 3095, 3258
Platforms: Windows
Checklist
Fixes issues
Fixes GTA5_b3095.exe!sub_141163854 (0x456)