-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin package versions in Setup.py #55
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not pin to a specific version unless absolutely necessary. If you do need to pin to a specific version then please include documentation for why. Pins in our Python packages should try to be as loose as possible within compatibility constraints.
Roger that @mcdonnnj ! Would a minimum version be acceptable at least? I was trying to pin the ones using request APIs like dnspython, ipwhois, and urllib3 just because I would worry the api for those could change (dnspython already is trying to deprecate the query API). Though if you think those are safe I would trust you more on those and I can just make the specific version pins all There does seem to be an issue with Python 3.6 but I think that might just be a runner issue not specifically a code issue. Correct me if I am wrong though. |
@Pascal-0x90 Minimum and maximum bounds such as Python 3.6 is failing because there is no file available for Ubuntu 22.04 runners (new default for |
Touching on an issue brought up in #54 .
🗣 Description
For each package, updated the setup.py file to pin each package to a minimum requirement if
not a definite requirement.
💭 Motivation and context
To keep the versions of packages installed when setting up development, testing, and production
environments consistent and working with the tool. Ref #54 .
🧪 Testing
Reinstalled environment and ran tool tests with success.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist