Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipwhois does not specify an install version, which caused tests to fail in some environments #54

Open
S4lt5 opened this issue Nov 21, 2022 · 3 comments
Assignees
Labels
good first issue This issue or pull request is well-defined and good for newcomers

Comments

@S4lt5
Copy link

S4lt5 commented Nov 21, 2022

Somehow or another, in a test environment, "ipwhois" was installed at 0.XX instead of 1.2.0.

Running setup.py on this environment caused no complaints, but inexplicably the tests failed.

If I did not run the tests first, I would have not known anything was wrong.

"ipwhois",

I would suggest that:

  • Tests get run on setup.py to make sure everything is actually working
  • minimum version numbers are explicitly specified.
@mcdonnnj
Copy link
Member

The latter is the only solution that makes sense. Every one of our Python packages should ideally have their dependencies pinned to whatever range is strictly compatible.

@mcdonnnj mcdonnnj added the good first issue This issue or pull request is well-defined and good for newcomers label Nov 22, 2022
@Pascal-0x90
Copy link
Collaborator

I am going to spend some time this week going through the issues that have been open and address the PRs setup. Thank you for going through all this @Yablargo . These have been all some great suggestions. Look out in the near future for some comments on the other PRs and Issues.

@Pascal-0x90
Copy link
Collaborator

Added a PR for this. Hopefully this takes care of this. From now on any packages added to this repo should follow that style of keeping versions pinned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue or pull request is well-defined and good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants