Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feedback as part of discussions #21 #45

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: add feedback as part of discussions #21 #45

merged 3 commits into from
Oct 9, 2024

Conversation

xames3
Copy link
Collaborator

@xames3 xames3 commented Oct 8, 2024

NOTE: this shouldn't be part of this branch, my bad... please ignore the zombie branch.

Related to #21 (comment)

@xames3
feat: add feedback as part of discussions #21
d4a8922 
Related to #21 (comment)

Signed-off-by: Akshay Mestry <xa@mes3.dev>
@xames3 xames3 added documentation updates, additions, or improvements to the project’s documentation duplicate this issue or pull request already exists enhancement enhancements to existing functionality or the addition of new features question further information is requested by the team members or community miscellaneous miscellaneous changes and some of the general inner workings community contributions from the community or enhancements that support community engagement discussion needed pull requests that need community or team input before moving forward open science contributions that enhance transparency, reproducibility, or accessibility in line with Open Science work in progress pull requests that are not yet ready for review or merging ready for review pull requests that are finished and awaiting review by the team or community awaiting changes pull requests that need updates or corrections based on feedback approved pull requests that have passed review and are cleared for merging low priority pull requests that are less critical and can wait if necessary labels Oct 8, 2024
@xames3 xames3 self-assigned this Oct 8, 2024
@xames3
Copy link
Collaborator Author

xames3 commented Oct 8, 2024

@jfmartinez4, close this one after review #21

@xames3 xames3 linked an issue Oct 8, 2024 that may be closed by this pull request
Write out how do contribute to the SCHOOL Project #21
Open
@xames3
feat!: embed live interpreter and notebook
ed26e5d 
Signed-off-by: Akshay Mestry <xa@mes3.dev>
@xames3
refactor: use notebook directive instead of iframe
834a0ff 
Signed-off-by: Akshay Mestry <xa@mes3.dev>
@jfmartinez4
Copy link
Contributor

@xames3 just wanted to confirm I should merge this pull request.

@xames3
Copy link
Collaborator Author

xames3 commented Oct 9, 2024 •
edited
Loading

you can check the feedback link at the bottom of the sphinx website, click on it, it should take you to a discussion forum. If that looks fine, you may merge and close this request. I kept this opened for your review for the feedback gathering task. do let me know if you need any help, @jfmartinez4.

@jfmartinez4 jfmartinez4 merged commit 1a5ae0d into dev Oct 9, 2024
2 checks passed
@jfmartinez4 jfmartinez4 deleted the feature/jupyter-embedding-setup branch October 9, 2024 18:06
github-actions bot added a commit that referenced this pull request Oct 9, 2024
@github-actions
feat: add feedback as part of discussions #21 (#45)
6a42ef2 
**NOTE:** this shouldn't be part of this branch, my bad... please ignore
the zombie branch.

Related to
#21 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyttmacmanus kyttmacmanus Awaiting requested review from kyttmacmanus

@jfmartinez4 jfmartinez4 Awaiting requested review from jfmartinez4

Assignees

@xames3 xames3

Labels
approved pull requests that have passed review and are cleared for merging awaiting changes pull requests that need updates or corrections based on feedback community contributions from the community or enhancements that support community engagement discussion needed pull requests that need community or team input before moving forward documentation updates, additions, or improvements to the project’s documentation duplicate this issue or pull request already exists enhancement enhancements to existing functionality or the addition of new features low priority pull requests that are less critical and can wait if necessary miscellaneous miscellaneous changes and some of the general inner workings open science contributions that enhance transparency, reproducibility, or accessibility in line with Open Science question further information is requested by the team members or community ready for review pull requests that are finished and awaiting review by the team or community work in progress pull requests that are not yet ready for review or merging
Projects
None yet
Milestone
m9: growing together (integrate feedb...
Development

Successfully merging this pull request may close these issues.

Write out how do contribute to the SCHOOL Project
2 participants
@xames3 @jfmartinez4