prevent return of None in write() #384
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves issue #379 for me. As @Jef-GB explained, the error occurs for smaller block sizes. The error occurs when the write() function of the BlockDownloadStream class returns None a second time while the input buffer is not read a second time.
Somehow in this case the buffer does not get refilled.
This change ensures that the function always returns a length. However, if there aren't enough bytes in the buffer, the function now returns the number of bytes remaining, but saves and sends them on the next transmission.
I do not think this is the ideal solution, but I am out of ideas.