(#2173) Load plugins configuration from the system directory #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins need to load configuration that is managed system-wide by Puppet even when the user is using their own configuration file. Regardless of the configuration file loaded (system one or user one), we want to load these plugins configuration from the system. We previously inferred the plugins configuration directory relatively to the rest of the configuration, but ignored it if it was located in the user HOME directory. This was not correct, and even caused more trouble when the HOME environment variable was '/' as it is commonly on some systems for services, because plugins configuration was never loaded on these systems. Fix this by detecting the location of the system configuration and unconditionally loading plugins configuration from this directory.
|
Oh god, fixing the CI looks so 🤦. Before changing a trillion lines of code to introduce some kind of structure to allow passing a custom directory, I would like to be sure that this is going in the right direction. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins need to load configuration that is managed system-wide by Puppet even when the user is using their own configuration file. Regardless of the configuration file loaded (system one or user one), we want to load these plugins configuration from the system.
We previously inferred the plugins configuration directory relatively to the rest of the configuration, but ignored it if it was located in the user HOME directory. This was not correct, and even caused more trouble when the HOME environment variable was '/' as it is commonly on some systems for services, because plugins configuration was never loaded on these systems.
Fix this by detecting the location of the system configuration and unconditionally loading plugins configuration from this directory.