Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klifs #58

Merged
merged 50 commits into from
Oct 16, 2024
Merged

Klifs #58

merged 50 commits into from
Oct 16, 2024

Conversation

jessicaw9910
Copy link
Collaborator

@jessicaw9910 jessicaw9910 commented Sep 24, 2024

Description

Solve partial alignments (e.g., b.l region) and non-contiguous adjacent region issues (e.g., III:aC) in KLIFS pocket

Todos

  • Streamline DICT_POCKET_KLIFS_REGIONS
  • Add annotations for non-contiguous regions after manual review of KLIFS structures
  • Add non-contiguous logic to iterate_klifs_alignment function that concatenates with previous region instead
  • Incorporate KLIFSPocket class into klifs module instead of kinase_schema
  • Update relevant notebooks
  • Allow for partial alignment of otherwise unmatched regions
  • Add Pydantic model to harmonize database information
  • Restrict partial alignment to kinase domain

Questions

  • How to allow for partial alignments and to check that they've worked

Status

  • In progress

jessicaw9910 and others added 4 commits September 24, 2024 14:53
… KLIFS regions after reviewing structurally alignments manually and updated iterate_klifs_alignment function accordingly; started movign KLIFSPocket dataclass into klifs module
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 12.42236% with 423 lines in your changes missing coverage. Please review.

Project coverage is 45.97%. Comparing base (59501fa) to head (ad5568f).
Report is 1 commits behind head on main.

Additional details and impacted files

jessicaw9910 and others added 25 commits September 24, 2024 15:24
Resolved conflicts from pre-commit.ci
…name; then converted search in database notebook to UniProt ID instead of HGNC gene name
…of databases and Pydantic model generation; updated databases notebook and source files in data dir
…of databases and Pydantic model generation; updated databases notebook and source files in data dir

rebased kinase schema
pre-commit-ci bot and others added 21 commits October 9, 2024 14:38
…ion, and all other remaining partial alignments
…h a generator validation function for the latter
@jessicaw9910 jessicaw9910 merged commit 67e2730 into main Oct 16, 2024
11 checks passed
jessicaw9910 added a commit that referenced this pull request Oct 17, 2024
* simplified DICT_POCKET_KLIFS_REGIONS, have added notion of contiguous KLIFS regions after reviewing structurally alignments manually and updated iterate_klifs_alignment function accordingly; started movign KLIFSPocket dataclass into klifs module

* adjusted KLIFS pocket notebook to adapt to klifs module changes

* adjusted KLIFS pocket notebook to adapt to klifs module changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* flake8 fix for unused import

* added initial find_start_or_end_recursively function

* added initial kinase Pydantic schema

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* latest kinase Pydantic schema

Resolved conflicts from pre-commit.ci

* added csv files to data and updated database notebook

* caching latest klifs pocket notebook

* refactored model schema so that each database module has its own BaseModel that is included in Kinase object

* klifs

* updated KinaseInfo to use more general search term in lieu of kinase name; then converted search in database notebook to UniProt ID instead of HGNC gene name

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* completed intial version of kinase_schema to allow for harmonization of databases and Pydantic model generation; updated databases notebook and source files in data dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed F401 and F722 errors in kinase_schema

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* completed intial version of kinase_schema to allow for harmonization of databases and Pydantic model generation; updated databases notebook and source files in data dir

rebased kinase schema

* used Kincore2UniProtAligner from aligment module in kincore module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* reverting to previous changes lost in rebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed E266 flake8 error

* started adding b.l alignment

* added get_repo_root util lost after last rebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added validation to fix incorrect KLIFS pocket for ADCK3

* used Self instead of self for ADCK3 KLIFS pocket validation fix

* final commit before moving all functions to KLIFSPocket class

* interim commit of klifs_pocket notebook while debugging bl alignment algorithm

* added SO link to ADCK3 validator for future reference

* added matplotlib_venn in dependencies

* added validation correction for LRRK2 and CAMKK1 KLIFS pockets

* finalized alignment algorithm for b.l, multi-matching post-concatenation, and all other remaining partial alignments

* final notebook including partial alignment issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed extraneous dev code from klifs_pocket notebook

* removed TODO from completed KLIFS tasks

* added biopython to devtools test env for CI

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* deleted unnecessary commented out code

* removed commented out code now integrated into return_idx_of_alignment_match

* added generate_alignment to KLIFSPocket and added to pre-init

* added bool_offset and KLIFS2UniProt to KinaseInfo BaseModel along with a generator validation function for the latter

* updated KLIFS pocket notebook for latest kinase schema including KLIFS2UniProt dict

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
jessicaw9910 added a commit that referenced this pull request Oct 17, 2024
* separating out CI badges given monorepo structure

* changed repo extension configuration

* changed max depth given monorepo

* added [tool.setuptools.packages.find] / where = [.] to databases pyproject.toml

* pip install sub-package in readthedocs.yml; may also need to change docs/requirements.txt

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* updated sphinx-rtd-theme in requirements.txt

* moved requirements.txt forward in readthedocs.yml

* added docs packages to requirements.yaml since requirements.txt seeming to be ignored

* fixed getting started code block

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* excluding tests

* fixed inline code

* max depth 3

* updated to exclude tests directories and contents

* instantiation of experiments subpackage

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] pre-commit autoupdate (#61)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/asottile/pyupgrade: v3.16.0 → v3.17.0](asottile/pyupgrade@v3.16.0...v3.17.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Klifs (#58)

* simplified DICT_POCKET_KLIFS_REGIONS, have added notion of contiguous KLIFS regions after reviewing structurally alignments manually and updated iterate_klifs_alignment function accordingly; started movign KLIFSPocket dataclass into klifs module

* adjusted KLIFS pocket notebook to adapt to klifs module changes

* adjusted KLIFS pocket notebook to adapt to klifs module changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* flake8 fix for unused import

* added initial find_start_or_end_recursively function

* added initial kinase Pydantic schema

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* latest kinase Pydantic schema

Resolved conflicts from pre-commit.ci

* added csv files to data and updated database notebook

* caching latest klifs pocket notebook

* refactored model schema so that each database module has its own BaseModel that is included in Kinase object

* klifs

* updated KinaseInfo to use more general search term in lieu of kinase name; then converted search in database notebook to UniProt ID instead of HGNC gene name

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* completed intial version of kinase_schema to allow for harmonization of databases and Pydantic model generation; updated databases notebook and source files in data dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed F401 and F722 errors in kinase_schema

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* completed intial version of kinase_schema to allow for harmonization of databases and Pydantic model generation; updated databases notebook and source files in data dir

rebased kinase schema

* used Kincore2UniProtAligner from aligment module in kincore module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* reverting to previous changes lost in rebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed E266 flake8 error

* started adding b.l alignment

* added get_repo_root util lost after last rebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added validation to fix incorrect KLIFS pocket for ADCK3

* used Self instead of self for ADCK3 KLIFS pocket validation fix

* final commit before moving all functions to KLIFSPocket class

* interim commit of klifs_pocket notebook while debugging bl alignment algorithm

* added SO link to ADCK3 validator for future reference

* added matplotlib_venn in dependencies

* added validation correction for LRRK2 and CAMKK1 KLIFS pockets

* finalized alignment algorithm for b.l, multi-matching post-concatenation, and all other remaining partial alignments

* final notebook including partial alignment issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed extraneous dev code from klifs_pocket notebook

* removed TODO from completed KLIFS tasks

* added biopython to devtools test env for CI

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* deleted unnecessary commented out code

* removed commented out code now integrated into return_idx_of_alignment_match

* added generate_alignment to KLIFSPocket and added to pre-init

* added bool_offset and KLIFS2UniProt to KinaseInfo BaseModel along with a generator validation function for the latter

* updated KLIFS pocket notebook for latest kinase schema including KLIFS2UniProt dict

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* added KinCore FASTA sequence file

* updated data README to summarize how the csv files were generated and how the Pydantic models can be assembled

* fixed KLIFS README

* added trailing space README

* pip install sub-package in readthedocs.yml; may also need to change docs/requirements.txt

* moved requirements.txt forward in readthedocs.yml

* push to trigger README reformat

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Mark Polk <mark.polk@choderalab.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant