Spawn message_callback to not block eventloop.

In case the message_callback takes a long time to return, this would affect the MQTT loop (e.g. keep-alive messages are not sent / responded in time). Closes #57.
chirpstack · Jul 10, 2024 · 92ec502 · 92ec502
1 parent 4879cf7
commit 92ec502
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/mqtt.rs b/src/mqtt.rs
@@ -218,9 +218,13 @@ pub async fn setup(conf: &Configuration) -> Result<()> {
 
                         match v {
                             Event::Incoming(Incoming::Publish(p)) => {
-                                if let Err(e) = message_callback(p).await {
-                                    error!("Handling message error, error: {}", e);
-                                }
+                                tokio::spawn({
+                                    async move {
+                                        if let Err(e) = message_callback(p).await {
+                                            error!("Handling message error, error: {}", e);
+                                        }
+                                    }
+                                });
                             }
                             Event::Incoming(Incoming::ConnAck(v)) => {
                                 if v.code == ConnectReturnCode::Success {