Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user/e16: new package #3185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

digitalrane
Copy link

This MR adds the enlightenment X11 window manager, DR16 version 1.0.30, which is still actively maintained upstream and the latest stable version. This is maintained and still developed as and alternative to newer versions of enlightenment.

I have built and tested this locally, including launching and interacting with various applications, enabling compositing mode, and switching themes and all works well. I have tested it using emptty as a display manager and can confirm the session files upstream E16 provides are correctly registered when the package is installed.

This is my first contribution to cports so if there is any feedback or tips on how to contribute changes better please let me know!

user/e16/template.py Outdated Show resolved Hide resolved
user/e16/template.py Outdated Show resolved Hide resolved
user/e16/template.py Outdated Show resolved Hide resolved
user/e16/template.py Outdated Show resolved Hide resolved
user/e16/template.py Outdated Show resolved Hide resolved
@nekopsykose
Copy link
Contributor

you'll also need an update.py that works to get the latest version, see other ones in the repo for examples

@nekopsykose
Copy link
Contributor

url = "https://sourceforge.net/projects/enlightenment/rss" is probably what you want for update.py

@digitalrane
Copy link
Author

you'll also need an update.py that works to get the latest version, see other ones in the repo for examples

OK thanks, that's good to know. I figured that was more for things like Python library and such, but I can see the update.py is really super flexible and can be used for anything, so TIL. Thanks for the advice, I've added and tested an update.py for this package.

@digitalrane
Copy link
Author

thank you for the review @nekopsykose! I think i've addressed all of the feedback now, if you get a chance to review again that would be really appreciated. I tested the updated package with the discussed changes and everything seems to work well.

user/e16/update.py Outdated Show resolved Hide resolved
user/e16/template.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants