Add standard-rails #1190
Merged
Add standard-rails #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was mentioned in #1137 and it should be helpful to keep around to make sure we're following some standard style practices with Rails
jim
approved these changes
Nov 14, 2023
|
I think the new errors are because erblint uses rubocop under the hood and this updated the rubocop version. I cleaned up the errors and I think we're good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mentioned in #1137 and it should be helpful to keep around to make sure we're following some standard style practices with Rails
What it does
Adds extra Rails-centric rules to the Ruby linter.
Why it is important
Keeps all contributors writing similar looking code.