-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A small improvement #3
base: main
Are you sure you want to change the base?
A small improvement #3
Conversation
This looks like a really nice addition, thanks for the PR! I'll just do some testing with it when I get home before I merge it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is, I've updated it. I admit that my Prettier (https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) wants to fix a lot of things Regarding the buttons, I admit that the way you've done them isn't extremely good. If you want, we can merge the PR, and later in the evening (GMT +1 timezone), I'll submit a PR where I fix your HTML a bit and the way things work (HTML & CSS). |
lore-generator/script.js
Outdated
@@ -184,7 +184,7 @@ document.addEventListener('DOMContentLoaded', function () { | |||
return ''; | |||
|
|||
let code = 'set lore of {_item} to '; | |||
const formattedLines = loreLines.map(line => `"${line.replace(/"/g, '""')}"`); | |||
const formattedLines = loreLines.map(line => `'${line.replace(/'/g, '''')}'`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually changing the functionality
I'll look into making a Prettier config, wasnt aware of that extension. At the very least, I'll make a readme and include some of the basic styling stuff in there. And I think I'd rather merge a fully working version rather than two PRs, so if you want to just include any further changes in this one, feel free! |
Alright, I'll look into it then. |
I've added a Prettier config file, and updated all files so far to use it 👍 |
Lore update :