pidfd: block SIGCHLD during tmp process creation #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Radostin! Thanks a lot for looking into it! We had a call with Bhavik today and he wants to see if we can use pstree helpers to solve this problem. So, let's wait a bit with merging this. |
No worries, I just wanted to confirm that the pidfd_dead test will pass with these changes in CI.
I'm not sure how easy it would be to do that but the messages in the following commits might help: c09ba04 5f72963 |
avagin
reviewed
Oct 14, 2024
rst0git
force-pushed
the
pidfd-sigchld
branch
from
794f5e3
to
2f5e4f5
Compare
avagin
reviewed
Oct 14, 2024
|
LGTM |
rst0git
force-pushed
the
pidfd-sigchld
branch
from
2f5e4f5
to
68c61f1
Compare
This patch blocks SIGCHLD during temporary process creation to prevent a race condition between kill() and waitpid() where sigchld_handler() causes `criu restore` to fail with an error. Fixes: checkpoint-restore#2490 Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com> Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git
force-pushed
the
pidfd-sigchld
branch
from
68c61f1
to
66f165e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates pidfd to block
SIGCHLDduring temporary process creation to prevent a race condition betweenkill()andwaitpid()wheresigchld_handler()causescriu restoreto fail with an error.Fixes: #2490