Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vma: Add !VVAR condition to vma_entry_can_be_lazy #2272

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

yota9
Copy link
Contributor

@yota9 yota9 commented Sep 28, 2023

Currently most of the times we don't have problems with VVAR segment and
lazy restore because when VDSO is parked there is an munmap call that
calls UFFDIO_UNREGISTER on the destination address.
But we don't want to enable userfaultfd for VDSO and VVAR at the first
place.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1e4f5fb) 70.54% compared to head (1c5357b) 70.54%.

❗ Current head 1c5357b differs from pull request most recent head df497f2. Consider uploading reports for the commit df497f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           criu-dev    #2272   +/-   ##
=========================================
  Coverage     70.54%   70.54%           
=========================================
  Files           133      132    -1     
  Lines         33522    33510   -12     
=========================================
- Hits          23647    23640    -7     
+ Misses         9875     9870    -5     
Files Coverage Δ
criu/include/vma.h 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avagin avagin requested a review from rppt September 28, 2023 18:38
@avagin
Copy link
Member

avagin commented Sep 28, 2023

lgtm

@rppt
Copy link
Member

rppt commented Sep 29, 2023

AFAIU Currently most of the times we don't have problems with VVAR segment due
to during parking vdso on it's old place mremap is used and during it
munmap is called to destination address which results in calling
UFFDIO_UNREGISTER. But as for VDSO we don't want to enable uffd for these addresses at firse place.

I find the changelog a bit hard to parse, how about

Currently most of the times we don't have problems with VVAR segment and lazy restore because when VDSO is parked there is an munmap call that calls UFFDIO_UNREGISTER on the destination address.
But we don't want to enable userfaultfd for VDSO and VVAR at the first place.

Other than that, LGTM

Currently most of the times we don't have problems with VVAR segment and
lazy restore because when VDSO is parked there is an munmap call that
calls UFFDIO_UNREGISTER on the destination address.
But we don't want to enable userfaultfd for VDSO and VVAR at the first
place.
@yota9
Copy link
Contributor Author

yota9 commented Sep 29, 2023

@rppt Thanks, done. Please merge it since I don't have rights.

@avagin avagin merged commit 4f0c07f into checkpoint-restore:criu-dev Sep 29, 2023
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants