ci: stop testing ubuntu overlayfs #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avagin
force-pushed
the
ubuntu-overlayfs
branch
from
cfe01a5
to
1607f0f
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2268 +/- ##
============================================
- Coverage 70.51% 70.48% -0.04%
============================================
Files 132 132
Lines 33507 33506 -1
============================================
- Hits 23628 23616 -12
- Misses 9879 9890 +11 ☔ View full report in Codecov by Sentry. |
|
So the fix is basically to bind mount the criu directory from the outside in the test container and being independent of the file system used by the container. Took me a while to spot that change. Would have been good to mention the change in the commit message. Besides that both changed tests are happy. LGTM. |
They break it with each kernel rebase. More details are here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257 Last time, it was fixed a few month ago and it has been broken again in 5.15.0-1046-azure. Let's bind-mount the CRIU directory into a test container to make it independent of a container file system. Signed-off-by: Andrei Vagin <avagin@gmail.com>
avagin
force-pushed
the
ubuntu-overlayfs
branch
from
1607f0f
to
006aafb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They break it with each kernel rebase. More details are here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257
Last time, it was fixed a few month ago and it has been broken again in 5.15.0-1046-azure.