Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmap: scan user-provided paths in order #2236

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

osctobe
Copy link
Contributor

@osctobe osctobe commented Aug 4, 2023

Make the scan use the order of paths that came from the user.

This assumes that the order actually matters and makes it easier to construct the list as to speed up inotify-using binaries.

Make the scan use the order of paths that came from the user.

Fixes: 4f2e4ab ("irmap: add --irmap-scan-path option"; 2015-09-16)
Signed-off-by: Michał Mirosław <emmir@google.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (1db922f) 70.69% compared to head (6d79e1e) 70.62%.

❗ Current head 6d79e1e differs from pull request most recent head e1a317e. Consider uploading reports for the commit e1a317e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2236      +/-   ##
============================================
- Coverage     70.69%   70.62%   -0.08%     
============================================
  Files           133      134       +1     
  Lines         33319    33220      -99     
============================================
- Hits          23555    23461      -94     
+ Misses         9764     9759       -5     
Files Changed Coverage Δ
criu/irmap.c 85.33% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osctobe osctobe requested a review from avagin August 4, 2023 12:39
@avagin avagin merged commit 72494ed into checkpoint-restore:criu-dev Aug 4, 2023
@osctobe osctobe deleted the irmap-order branch August 9, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants