Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: run tests with Fedora 38 #2181

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented May 20, 2023

This pull request updates the version of vagrant from 2.2.19 to 2.3.7, and the base Fedora VM image from 37 to 38.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (03541c0) 70.59% compared to head (600f981) 70.65%.

❗ Current head 600f981 differs from pull request most recent head e470c6d. Consider uploading reports for the commit e470c6d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2181      +/-   ##
============================================
+ Coverage     70.59%   70.65%   +0.05%     
============================================
  Files           133      133              
  Lines         33324    33326       +2     
============================================
+ Hits          23525    23545      +20     
+ Misses         9799     9781      -18     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avagin
Copy link
Member

avagin commented May 22, 2023

The vagrant test fails. Pls investigate what is going on there.

@adrianreber
Copy link
Member

The vagrant test fails. Pls investigate what is going on there.

It says no space left on device. @rst0git maybe you need to increase the vagrant disk size

@rst0git
Copy link
Member Author

rst0git commented May 26, 2023

It says no space left on device. @rst0git maybe you need to increase the vagrant disk size

I tried increasing the disk size, but it fails with the same error. Here is the output of df from the vagrant VM in CI:

$ df -h
Filesystem      Size  Used Avail Use% Mounted on
devtmpfs        4.0M     0  4.0M   0% /dev
tmpfs           2.0G   84K  2.0G   1% /dev/shm
tmpfs           781M  644K  780M   1% /run
/dev/vda5        39G  2.3G   37G   6% /
tmpfs           2.0G     0  2.0G   0% /tmp
/dev/vda2       966M  107M  794M  12% /boot
/dev/vda3       100M   12M   89M  12% /boot/efi
/dev/vda5        39G  2.3G   37G   6% /home
tmpfs           391M     0  391M   0% /run/user/1000

@adrianreber
Copy link
Member

It says no space left on device. @rst0git maybe you need to increase the vagrant disk size

I tried increasing the disk size, but it fails with the same error. Here is the output of df from the vagrant VM in CI:

$ df -h
Filesystem      Size  Used Avail Use% Mounted on
devtmpfs        4.0M     0  4.0M   0% /dev
tmpfs           2.0G   84K  2.0G   1% /dev/shm
tmpfs           781M  644K  780M   1% /run
/dev/vda5        39G  2.3G   37G   6% /
tmpfs           2.0G     0  2.0G   0% /tmp
/dev/vda2       966M  107M  794M  12% /boot
/dev/vda3       100M   12M   89M  12% /boot/efi
/dev/vda5        39G  2.3G   37G   6% /home
tmpfs           391M     0  391M   0% /run/user/1000

That is strange. Can you re-create this error locally using Vagrant?

@rst0git
Copy link
Member Author

rst0git commented Jun 7, 2023

Can you re-create this error locally using Vagrant?

Yes, the same error appears when running make -C scripts/ci vagrant-fedora-rawhide locally.

This patch also updated the download URL format

from
    https://releases.hashicorp.com/vagrant/2.3.7/vagrant_2.3.7_x86_64.deb

to
    https://releases.hashicorp.com/vagrant/2.3.7/vagrant_2.3.7-1_amd64.deb

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@avagin avagin merged commit 82bfb67 into checkpoint-restore:criu-dev Sep 4, 2023
31 of 37 checks passed
@avagin
Copy link
Member

avagin commented Sep 4, 2023

@adrianreber sorry, I clicked rebase-and-merge and only then noticed that @rst0git requested your review. Pls take a look and if here is something wrong, we will fix on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants