fix(backend): don't generate invalid commits for non-bumped packages

chaotic-cx · Nov 18, 2024 · d3f872e · d3f872e
1 parent 912ae93
commit d3f872e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/backend/src/interfaces/repo-manager.ts b/backend/src/interfaces/repo-manager.ts
@@ -59,6 +59,7 @@ export interface RepoUpdateRunParams {
     configs: CiConfigs;
     pkg: Package;
     triggerFrom: TriggerType;
+    gotBumped: boolean
 }
 
 export type CiConfigs = { [key: string]: string };

diff --git a/backend/src/repo-manager/repo-manager.service.ts b/backend/src/repo-manager/repo-manager.service.ts
@@ -548,9 +548,10 @@ class RepoManager {
             return { repo: repo.name, bumped: [], origin: TriggerType.ARCH };
         }
         const bumpedPackages: PackageBumpEntry[] = await this.bumpPackages(needsRebuild, repoDir);
+        const needsPush = needsRebuild.filter(entry => entry.gotBumped === true)
 
         Logger.log(`Pushing changes to ${repo.name}`, "RepoManager");
-        await this.pushChanges(repoDir, needsRebuild, repo);
+        await this.pushChanges(repoDir, needsPush, repo);
 
         Logger.debug("Done checking for rebuild triggers, cleaning up", "RepoManager");
         this.cleanUp([repoDir, ...pkgbaseDirs]);
@@ -844,9 +845,11 @@ class RepoManager {
                     });
                 }
             }
-
             void this.dbConnections.packages.save(param.pkg);
 
+            // Indicate we bumped the package
+            param.gotBumped = true
+
             // We need to update the package in the database to reflect the new bump
             const bumpEntry: PackageBumpEntry = {
                 pkg: param.pkg,