chore: add requirement validation #1559
Merged
+215
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Nov 20, 2024
| repeated string requirements = 6; | ||
| repeated string requirements = 6 [(buf.validate.field).repeated.items = { | ||
| string: { | ||
| pattern: "^[^\\s@]+(@[^\\s@]+)?$", // whitespaces not allowed, lock is optional (@) |
There was a problem hiding this comment.
I know that I said we should force it but now I am wondering if we should be lax by default as you did. What do you think?
There was a problem hiding this comment.
Yes, but at least I would force the @ for the version separator (or /, or :, anything), as we do in other places
There was a problem hiding this comment.
I've updated the rule to have a mandatory requirement prefix for grouping them into frameworks, groups, or similar. myframework/myrequirement@version
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some validation to the requirement IDs, allowing only non space characters an 1
@only to split versions.Closes #1558