Add Macdown as an exception to minimal-socket-client-macos #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jed Salazar <jedsalazar@gmail.com>
tstromberg
approved these changes
Dec 20, 2023
|
@tstromberg thanks for the LGTM! Looks like the verify/build tests were canceled, maybe due to a timeout? |
|
Re-kicked the test and it timed out again. Looks like previous tests have failed for PRs that merged. I'm going to merge but let me know if I need to fix anything. |
|
Yeah, the addition of YARA rules appear to have caused our CI to timeout. We need to find the rules and disable them in our test rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an exception for the Macdown application. Let me know if this isn't the correct spot for an exception