Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few parser edge cases triggered by OpenBLAS #6

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Fix a few parser edge cases triggered by OpenBLAS #6

merged 4 commits into from
Aug 18, 2023

Conversation

kaniini
Copy link
Contributor

@kaniini kaniini commented Aug 18, 2023

OpenBLAS has two things previously unaccounted for in our parser:

  • Empty variable assignment (libversion=\n)
  • Version as variable (Version: ${version}\n)

@kaniini
package: allow value parts of variable and property declarations to b…
cb5eed9 
…e blank

Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
parser: perform variable substitutions on properties
a373b4b 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
add testcase for parsing the OpenBLAS config
46974ac 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini
add nolint to replaceVariables
f8f010b 
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini kaniini merged commit bee0072 into main Aug 18, 2023
3 checks passed
@kaniini kaniini deleted the feature/openblas branch August 18, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaniini @dlorenc @jonjohnsonjr