Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy annotations to config labels #1215

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

imjasonh
Copy link
Member

No description provided.

Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

imjasonh commented Jul 23, 2024

https://github.com/chainguard-dev/apko/actions/runs/10062235454/job/27814248619 demonstrates that this change doesn't change images that don't have annotations (TestPublish passes without changes to the digest).

Images that specify annotations will produce different config blobs, which change image digests, which change index digests, and SBOM blobs.

@imjasonh imjasonh enabled auto-merge (squash) July 23, 2024 15:58
@imjasonh imjasonh merged commit 1b878b0 into chainguard-dev:main Jul 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants