This repository has been archived by the owner on Nov 10, 2018. It is now read-only.
Update validate.js #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you make your own validation (e.g. I had to compare the values of 2 fields) using field.setCustomValidity(customErrorMessageOfSomeKind) the generic error will currently be shown, just have to add these 3 lines to catch the right error message (I apologize for being lazy and just changing this one file and not in the dist folder etc.)
|
Possible duplicate of #46? |
|
Maybe 2 sides of the same issue? #46 is just about the polyfill, but there's apparently also no support for it without the polyfill |
|
Sorry for the delay. I'll merge this soon! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you make your own validation (e.g. I had to compare the values of 2 fields) using
field.setCustomValidity(customErrorMessageOfSomeKind)
the generic error will currently be shown, just have to add these 3 lines to catch the right error message (I apologize for being lazy and just changing this one file and not in the dist folder etc.)