Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor security schemes #221

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Refactor security schemes #221

merged 1 commit into from
Nov 17, 2024

Conversation

emmanuelgautier
Copy link
Member

@emmanuelgautier emmanuelgautier commented Nov 11, 2024

This PR aims to prepare support for more security schemes and how the tokens are passed

@emmanuelgautier emmanuelgautier added this to the v0.9 milestone Nov 11, 2024
@emmanuelgautier emmanuelgautier marked this pull request as draft November 11, 2024 18:46
jwt/jwt.go Fixed Show fixed Hide fixed
jwt/jwt.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 75.58140% with 105 lines in your changes missing coverage. Please review.

Project coverage is 55.90%. Comparing base (c03793a) to head (8a7e70f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/auth/security_scheme.go 87.21% 13 Missing and 4 partials ⚠️
internal/auth/oauth.go 66.66% 8 Missing and 4 partials ⚠️
internal/auth/bearer.go 60.00% 6 Missing and 4 partials ⚠️
...en_authentication/jwt/not_verified/not_verified.go 44.44% 7 Missing and 3 partials ⚠️
internal/auth/api_key.go 52.94% 5 Missing and 3 partials ⚠️
openapi/security_scheme.go 70.37% 5 Missing and 3 partials ⚠️
...oken_authentication/jwt/weak_secret/weak_secret.go 53.84% 4 Missing and 2 partials ⚠️
...can/broken_authentication/jwt/alg_none/alg_none.go 77.27% 3 Missing and 2 partials ⚠️
...en_authentication/jwt/blank_secret/blank_secret.go 64.28% 3 Missing and 2 partials ⚠️
...uthentication/jwt/null_signature/null_signature.go 64.28% 3 Missing and 2 partials ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   57.01%   55.90%   -1.12%     
==========================================
  Files          88       90       +2     
  Lines        3462     3533      +71     
==========================================
+ Hits         1974     1975       +1     
- Misses       1367     1415      +48     
- Partials      121      143      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmanuelgautier emmanuelgautier changed the title Improve and add support for more OpenAPI security schemes Refactor security schemes Nov 17, 2024
@emmanuelgautier emmanuelgautier marked this pull request as ready for review November 17, 2024 18:05
@emmanuelgautier emmanuelgautier merged commit 841b62c into main Nov 17, 2024
22 of 23 checks passed
@emmanuelgautier emmanuelgautier deleted the openapi-security-schemes branch November 17, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant