Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix useless permission required and improve perf for mssql db size mode #5266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tanguyvda
Copy link
Contributor

Community contributors

Description

  • remove the USE $database because the query after that doesn't require us to be inside the database
  • move the database size query outside of the for loop because it makes no sens to run it for every database when said query returns the size of each database anyway

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

I have no clue

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

@tanguyvda tanguyvda requested a review from a team as a code owner October 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant