fix(websso) remove exception when REMOTE_USER does not exist

centreon · Oct 28, 2022 · 3c28e12 · 3c28e12
1 parent f9efb6d
commit 3c28e12
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/src/Core/Security/Authentication/Infrastructure/Provider/WebSSO.php b/src/Core/Security/Authentication/Infrastructure/Provider/WebSSO.php
@@ -162,7 +162,6 @@ public function authenticateOrFail(LoginRequest $request): void
     {
         $this->info('Authenticate the user');
         $this->ipIsAllowToConnect($request->clientIp);
-        $this->validateLoginAttributeOrFail();
     }
 
     /**
@@ -212,7 +211,7 @@ public function ipIsAllowToConnect(string $ipAddress): void
     /**
      * Validate that login attribute is defined in server environment variables
      */
-    public function validateLoginAttributeOrFail(): void
+    public function loginAttributeIsValid(): bool
     {
         /** @var CustomConfiguration $customConfiguration */
         $customConfiguration = $this->getConfiguration()->getCustomConfiguration();
@@ -221,8 +220,11 @@ public function validateLoginAttributeOrFail(): void
             $this->error('login header attribute not found in server environment', [
                 'login_header_attribute' => $customConfiguration->getLoginHeaderAttribute()
             ]);
-            throw new InvalidArgumentException('Missing Login Attribute');
+
+            return false;
         }
+
+        return true;
     }
 
     /**

diff --git a/src/EventSubscriber/WebSSOEventSubscriber.php b/src/EventSubscriber/WebSSOEventSubscriber.php
@@ -121,13 +121,15 @@ public function loginWebSSOUser(RequestEvent $event): void
         }
 
         $this->info('Starting authentication with WebSSO');
-        $provider->authenticateOrFail(
-            LoginRequest::createForSSO($request->getClientIp())
-        );
+        if ($provider->loginAttributeIsValid()) {
+            $provider->authenticateOrFail(
+                LoginRequest::createForSSO($request->getClientIp())
+            );
 
-        $user = $provider->findUserOrFail();
-        $this->createSession($request, $provider);
-        $this->info('Authenticated successfully', ['user' => $user->getAlias()]);
+            $user = $provider->findUserOrFail();
+            $this->createSession($request, $provider);
+            $this->info('Authenticated successfully', ['user' => $user->getAlias()]);
+        }
     }
 
     /**