Bug fixes discovered during testing. #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmgdr
reviewed
Aug 22, 2023
aaronmgdr
reviewed
Aug 22, 2023
aaronmgdr
requested changes
Aug 22, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
soloseng
reviewed
Sep 11, 2023
| } | ||
|
|
||
| console.log('tx.feeCurrency', tx.feeCurrency); |
| const network = await getNetworkConfig(); | ||
| const provider = new CeloProvider(network.url); | ||
| const keyPair = await getKeyPair(snap, tx.from); | ||
| const wallet = new CeloWallet(keyPair.privateKey).connect(provider); | ||
| tx.from = tx.from ? tx.from : wallet.address; |
There was a problem hiding this comment.
not sure why this line was added.
If tx.from does not exist, than wallet cannot be generated, since keypair is using tx.from
If tx.from could in some cases be missing, should there be a check before line 44 that tx.from actually exist?
| export const REJECTION_MESSAGE = 'User rejected the request'; | ||
| export const INVALID_CURRENCY_MESSAGE = 'Invalid Currency'; | ||
| export const INSUFFICIENT_FUNDS_MESSAGE = `Insufficient funds for the provided gas currency to complete the operation. Please try again using another currency.`; | ||
| export const VALID_CURRENCIES = ['cusd', 'ceur', 'creal', 'celo']; |
There was a problem hiding this comment.
NIT: It's usually been convention to write these currencies in uppercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes celo-org/celo-monorepo#10495