This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Use raw data for Merkle tree inner nodes instead of serialization #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rify that NMT only operates on shares.
adlerjohn
added
bug
|
Can we use python as pseudo code (#108) while touching these lines? It will further disambiguate things. |
liamsi
reviewed
Jan 19, 2021
| ```C++ | ||
| node.n_min = d.namespaceID | ||
| node.n_max = d.namespaceID | ||
| node.v = h(0x00, serialize(d)) | ||
| node.v = h(0x00, d.rawData) |
There was a problem hiding this comment.
OK, that is the same as the current implementation 👍🏼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109.
Instead of serializing child nodes (which would require the use of a single serialization scheme but introduce a dependency on a serialization library to the trees), just use the raw bytes (which is technically a different serialization scheme but requires no library).