Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for accessing transports #421

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

santiagorodriguez96
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 commented Feb 2, 2024

Summary

Step 23 of the Registering a New Credential section of the WebAuthn Level 2 spec states:

It is RECOMMENDED to also:

Associate the credentialId with the transport hints returned by calling credential.response.getTransports(). This value SHOULD NOT be modified before or after storing it. It is RECOMMENDED to use this value to populate the transports of the allowCredentials option in future get() calls to help the client know how to find a suitable authenticator.

This PR adds the necessary interface for relying parties to easily access to this value, by doing:

WebAuthn::Credential.from_create(credential_params).response.transports # => ["internal"]

@santiagorodriguez96 santiagorodriguez96 merged commit 1370722 into master Mar 8, 2024
9 checks passed
@santiagorodriguez96 santiagorodriguez96 deleted the sr--add-support-for-transports branch March 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants