Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles update #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ByronGBP
Copy link

Hii!!

First of all, thanks for creating such an amazing tool!
I've been using this tool a lot and I just want to make my contribution as a token of appreciation.

I made some small styles updates, to overall give some air & start creating a hierarchy between all the elements.

This is the list of everything in this PR:

  • inside renderSandwichadd className "sandwich-image" & "sandwich-info"
  • add object-fit: cover to sandwich-image so it doesn't deform
  • add padding to sandwich-info to give some space
  • inside renderMath add className "ingredients-results"
  • add padding to "ingredients-results" to give some space
  • add row-gap to "ingredients-results" so its children have some space between them
  • inside renderMath group ingredients by flavour & filling in its own div with className "fillings" & "flavours"
  • inside renderMath group advanced-mode card in its own div with className "advanced-mode"
  • add max-width to "advanced-mode" to give some consistency
  • two small tweak for mobile

Check this screenshot to see the difference:

Screenshot 2022-12-20 at 00 44 23

Screenshot 2022-12-20 at 00 44 40

I hope you find this adequate.
I'm happy to keep helping!

Thanks 🤙

@@ -146,7 +146,7 @@
margin-top: 10px;
}

.complex-search-panel > * {
.complex-search-panel>* {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse those first "changes". Those were made automatically by my "prettier" plugin. Didn't see them 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant