Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comment quotes so that Emacs syntax highlighting works #533

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

rtmclay
Copy link

@rtmclay rtmclay commented Aug 6, 2024

Hi Xavier. I am trying to understand how you implement module-hide. As an Emacs user, the code highlighting sometimes get confused. If I add a # and a double quote on certain lines, it clears up the syntax highlighting. I checked to see if your .emacs tcl-mode-hook fixed the issue and it does not. Best, Robert.

@xdelaruelle
Copy link
Member

Hi Robert, I am adding a second commit to try an alternative approach as your suggested change is not a valid Tcl code. If the CI tests succeed, could you please check that Emacs highlighting is ok with the proposed change.

To understand module-hide I also suggest you look at the corresponding design notes: https://modules.readthedocs.io/en/latest/design/hide-or-forbid-modulefile.html

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (75ecbe1) to head (4dd810e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   99.39%   99.63%   +0.23%     
==========================================
  Files          15       15              
  Lines        5451     5430      -21     
==========================================
- Hits         5418     5410       -8     
+ Misses         33       20      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtmclay
Copy link
Author

rtmclay commented Aug 7, 2024

Your changes work well for me and Emacs. Thanks very much for this change and the link to your documentation. Feel free to close this PR. I'm happy.

Change {"} into \" not to break Emacs highlight mechanism.
@xdelaruelle xdelaruelle merged commit 9c25a0f into cea-hpc:main Aug 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants