Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ upload to Test PyPI for pushes on main #666

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Aug 9, 2024

Description

This PR updates the CD workflow so that anytime it runs on a push to main, it uploads the resulting package to Test PyPI. This allows to battle test the packages before official releases.
This will be especially important in the context of #662.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added github_actions Pull requests that update Github_actions code continuous integration Anything related to the CI setup packaging Anything related to Python packaging labels Aug 9, 2024
@burgholzer burgholzer self-assigned this Aug 9, 2024
@burgholzer
Copy link
Member Author

Unfortunately, it seems that this is not really feasible.
Test PyPI won't accept packages with local version identifiers and setuptools-scm does not easily allow to disable local versions, e.g., based on the presence of an environment variable.
Maybe sometime in the future.

@burgholzer burgholzer closed this Aug 9, 2024
@burgholzer burgholzer changed the title ⚗️ upload to Test PyPI when running CD workflow ⚗️ upload to Test PyPI for pushes on main Sep 27, 2024
@burgholzer burgholzer reopened this Sep 27, 2024
@burgholzer
Copy link
Member Author

Might have found a way to make this possible after all. Investigating further.

@burgholzer burgholzer force-pushed the test-pypi-upload branch 2 times, most recently from ed7497d to 6983abb Compare September 28, 2024 08:35
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.1%. Comparing base (aea7573) to head (0254d77).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #666   +/-   ##
=====================================
  Coverage   92.1%   92.1%           
=====================================
  Files        125     125           
  Lines      13757   13757           
  Branches    2150    2150           
=====================================
+ Hits       12671   12672    +1     
+ Misses      1086    1085    -1     
Flag Coverage Δ
cpp 91.8% <ø> (+<0.1%) ⬆️
python 99.7% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit c45b967 into main Sep 28, 2024
38 checks passed
@burgholzer burgholzer deleted the test-pypi-upload branch September 28, 2024 10:09
burgholzer added a commit that referenced this pull request Sep 28, 2024
## Description

A small follow-up PR to #666 that adjusts how the continuous deployment
job is run.
Hopefully, after merging, this allows to continuously upload to
TestPyPI.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup github_actions Pull requests that update Github_actions code packaging Anything related to Python packaging
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant