Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on VoxPupuli shared workflows #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smortex
Copy link

@smortex smortex commented Jan 11, 2023

This boillerplate is shared by all modules, and when regression happen,
all modules need to be updated. Using shared workflows will allow us to
benefit from VoxPupuli fixes without having to copy them manually.

@smortex
Copy link
Author

smortex commented Jan 11, 2023

For the record, we are currently needing this:
voxpupuli/gha-puppet#21

Example failure:
https://github.com/ccin2p3/puppet-patterndb/actions/runs/3879751201/jobs/6618098052

This boillerplate is shared by all modules, and when regression happen,
all modules need to be updated.  Using shared workflows will allow us to
benefit from VoxPupuli fixes without having to copy them manually.
@smortex
Copy link
Author

smortex commented Feb 10, 2023

@faxm0dem I used this to simplify and fix CI in the patterndb module (I run modulesync for that module from this branch to generate ccin2p3/puppet-patterndb#32 ).

I will open other PR with this code for puppet-syslog_ng and puppet-riemann to ensure that it works as expected.

@smortex
Copy link
Author

smortex commented Feb 10, 2023

The relevant branches:

@smortex smortex mentioned this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants