Fix issue with modifying a split transaction. #96
Conversation
# Conflicts: # jgnash-fx/src/main/java/jgnash/uifx/wizard/file/NewFileTwoController.java
If the local currency is unknown, it defaults to the pseudo-currency "XXX" with scale -1. This scale is not allowed for CurrencyNodes, so set it to 0 instead.
Even if the account combo box is locked in this case, the account is still shown to the user and later reused if a modified transaction entry is built.
Also, only include those child accounts that themselves are investment accounts. This solves two problems: Due to a race condition, the constructor is sometimes called with a non-investment account, which led to an IllegalArgumentException and later to NullPointerExceptions. And this now works recursively even if not all child accounts are investment accounts.
In some circumstances, the filteredList was empty when runLater() finally called setValue().
|
I have added two additional commits related to the Portfolio Report. They fix a condition in which the filter predicate of the account combo box is applied later than some of the other initializations. This caused exceptions like these:
and
|
If a split transaction was edited on the split end (i.e., in the register view of the account that is not the common account), the account of the transaction entry was not preserved. This made the transaction entry "jump" erratically to another account. The underlying reason is that the account was not put into the account combo box; although the combo box is disabled, its value is still used to build a modified transaction entry.