Add data transformation to new_feature_template #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
Damonamajor
commented
Aug 6, 2024
| @@ -0,0 +1,119 @@ | |||
| target_feature_value <- params$added_feature | |||
There was a problem hiding this comment.
These are used throughout all the other docs, without being explicitly mentioned in the others.
Damonamajor
commented
Aug 6, 2024
| select( | ||
| meta_pin, meta_card_num, pred_card_shap_baseline_fmv, | ||
| {{ target_feature_value }} | ||
| ) %>% |
There was a problem hiding this comment.
Renames the value to append _shap, allowing the feature value to be merged without creating .x, .y.
Damonamajor
commented
Aug 6, 2024
| ) | ||
|
|
||
| # Summarizing data by neighborhood code | ||
| card_nbhd <- card_individual %>% |
There was a problem hiding this comment.
These are mostly used for the ggplots for neighborhood mapping.
Damonamajor
commented
Aug 6, 2024
| ) %>% | ||
| ungroup() %>% | ||
| right_join(pin_individual, by = c("meta_pin" = "meta_pin")) %>% | ||
| mutate( |
There was a problem hiding this comment.
Removes the dollar::scales before dividing by it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the previous data transformation into five specific objectives.
Key changes
-The wonkiest part of this is the leaflet map, which pivots wider based on the different SHAP values. For example, if a pin has 4 cards, it has value_1, value_2 ,etc. allowing the leaflet map to display the individual value for each card, while plotting based on pin.
#250