Refactor pre-commit using composite action. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 12 12
Lines 478 478
=======================================
Hits 472 472
Misses 6 6 ☔ View full report in Codecov by Sentry. |
jeancochrane
approved these changes
Apr 29, 2024
|
@wagnerlmichael Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the pre-commit action to our composite action in the actions repo. Previously we were manually installing dependencies in the action. Since
pre-commit runhandles this automatically, I refactored the.pre-commit-config.yamlfile to look similar to other repos we have. It also now points to the repo URLs explicitly, which was needed to make sure the action worked after the removal of the pip installs.Note: for whatever reason, isort version 5.11.0 breaks the pre-commit, and bumping it to 5.120 fixes it.