Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique indices to identify datasets for appending #449

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

bkloeckl
Copy link
Contributor

Change the append dialog, get_compatibles and append_data functions to include original and unique indices used for identifying the data.

@cbrnr
Copy link
Owner

cbrnr commented Nov 18, 2024

Thanks @bkloeckl! The current changes lack the ability to sort datasets (via drag and drop) in the Source and Destination lists though, which I think we should not remove.

I would also keep it simpler, instead of using a table, I'd stick to a list, but just add the index to the label. This could also be done for the sidebar then. I'm not sure how and if such a label can be formatted nicely, e.g. it would be nice to have

  • numbers right-aligned
  • numbers use some lighter color (not black or white)

Something like this:

Screenshot 2024-11-18 at 09 17 41

If this requires a table (which might very well be the case), I'm sure that the style can be adapted so that it doesn't contain a header row or any borders.

src/mnelab/dialogs/append.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants