started working on distance based probabilities #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files |
custom residue hash
| @@ -102,7 +104,7 @@ def _update(self, candidates: list[tuple], nr_of_steps: int) -> None: | |||
| pass | |||
|
|
|||
| def _adapt_probabilities( | |||
| self, to_adapt=list[tuple[str, int, frozenset[str]]] | |||
| self, to_adapt=list[tuple[str, int, frozenset[str]]], K=int | |||
There was a problem hiding this comment.
Do not add K to the function signature here. It is already accessible inside the class (as defined in line 65) via self.K. Just use self.K in line 146 for the factor variable
…y was not working correctly, the same transfer was blocked but not the backwards reaction)
…donated H instead of exactly 1A if distance < 1.1A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include distance-based transfer probabilities based on RDF. Expand sim_pt.py with r_min (cuton) for each allowed update pair and add a function (None/linear/cosine) to StateUpdate to simulate.
Todos
Notable points that this PR has either accomplished or will accomplish.