Skip to content

Commit

Permalink
Ensure multi-frame responses are promoted correctly from the wait queue
Browse files Browse the repository at this point in the history
  • Loading branch information
marc-casperlabs committed Jan 22, 2024
1 parent f49741c commit a990a91
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,13 @@ where
// We finished sending an error frame, time to exit.
return Err(CoreError::RemoteProtocolViolation(frame_sent.header()));
}

// TODO: We should restrict the dirty-queue processing here a little bit
// (only check when completing a multi-frame message).
// A message has completed sending, process the wait queue in case we have
// to start sending a multi-frame message like a response that was delayed
// only because of the one-multi-frame-per-channel restriction.
self.process_wait_queue(frame_sent.header().channel())?;
} else {
#[cfg(feature = "tracing")]
tracing::error!("current frame should not disappear");
Expand Down

0 comments on commit a990a91

Please sign in to comment.