Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gUFO section of page for intervals of existence #148

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

ajnelson-nist
Copy link
Member

This PR is also tested with gUFO shapes in PR 147.

A follow-on patch will regenerate Make-managed files.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist marked this pull request as ready for review July 10, 2024 22:29
@ajnelson-nist
Copy link
Member Author

This PR is ready for review and merge.

```

Intervals of existence do not appear to be defined directly in gUFO. Also, since only the first and last instant of a concrete individual are specified, it is also not explicit in gUFO whether an individual's interval of existence needs to be continuous. For instance, a `gufo:Situation` may be seen to hold for a period of time (such as a person being a student in a `gufo:TemporaryInstantiationSituation`), then not hold (e.g., when the person graduates from a school), then hold again (e.g., when the person later enrolls in another school).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct in terms of its classification. There are two individuals involved, though, regarding the gufo:TemporaryInstantiationSituation. Leaving this out of the text might create confusion with the readers to understand there is only one single situation that is spread over two distinct enrollments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a footnote of this. I think explaining the other individual gets a little too big for a parenthetical remark.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footnote added. Please let me know if you think it needs further adjusting, or if it's better to just omit Situation discussion entirely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-picking here would be that it is, imo, not necessary to elaborate on how it is done, just the essentials that each distinct enrollment is represented as distinct gufo:TemporaryInstantiationSituations. As in: don't make it more complicated than it needs to be. But again, this is nit-picking because the purpose has been achieved already.

Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically there's nothing wrong, but the text in itself can be improved on one or two potentially confusing phrases. Once resolved I'm happy to click the merge buttons.

A follow-on patch will regenerate Make-managed files.

Requested-by: Paul Brandt <paul@brandt.name>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will regenerate Make-managed files.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Member Author

Correction: The commit that adds gUFO shapes review is this one, not the commit I'd originally linked.

A follow-on patch will regenerate Make-managed files.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Member Author

This commit reviews the gufo:Situation added in 2b42060.

Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this is fine. Added two unnecessary details :-)

A follow-on patch will regenerate Make-managed files.

Requested-by: Paul Brandt <paul@brandt.name>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Member Author

In general, this is fine. Added two unnecessary details :-)

Thank you. I've pushed the last textual changes and a regeneration patch.

@plbt5 plbt5 merged commit 478e4cf into master Jul 11, 2024
1 check passed
@plbt5 plbt5 deleted the existence_intervals branch July 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants